fix PT2_COMPLIANT_TAG macro #2223
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D52256752 |
zou3519
force-pushed
the
export-D52256752
branch
from
6aa36af
to
3c47eb3
Compare
zou3519
added a commit
to zou3519/FBGEMM
that referenced
this pull request
Dec 18, 2023
Summary: This macro checks a macro in torch/library.h. We need to import torch.library.h first, otherwise we erroneously set the macro to nothing. Reviewed By: williamwen42 Differential Revision: D52256752
|
This pull request was exported from Phabricator. Differential Revision: D52256752 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D52256752 |
zou3519
force-pushed
the
export-D52256752
branch
from
3c47eb3
to
0c4b233
Compare
zou3519
added a commit
to zou3519/FBGEMM
that referenced
this pull request
Dec 18, 2023
Summary: This macro checks a macro in torch/library.h. We need to import torch.library.h first, otherwise we erroneously set the macro to nothing. Reviewed By: williamwen42 Differential Revision: D52256752
|
This pull request was exported from Phabricator. Differential Revision: D52256752 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D52256752 |
Summary: It passes all tests. Reviewed By: williamwen42 Differential Revision: D52256116
Summary: It needed an abstract impl. Reviewed By: williamwen42 Differential Revision: D52256098
Summary: This macro checks a macro in torch/library.h. We need to import torch.library.h first, otherwise we erroneously set the macro to nothing. Reviewed By: williamwen42 Differential Revision: D52256752
zou3519
force-pushed
the
export-D52256752
branch
from
0c4b233
to
e13f6eb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52256752 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D52256752 |
|
This pull request has been merged in 9f426bb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This macro checks a macro in torch/library.h.
We need to import torch.library.h first, otherwise we erroneously set the macro
to nothing.
Reviewed By: williamwen42
Differential Revision: D52256752