-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix PT2_COMPLIANT_TAG macro #2223
Conversation
✅ Deploy Preview for pytorch-fbgemm-docs canceled.
|
This pull request was exported from Phabricator. Differential Revision: D52256752 |
6aa36af
to
3c47eb3
Compare
Summary: This macro checks a macro in torch/library.h. We need to import torch.library.h first, otherwise we erroneously set the macro to nothing. Reviewed By: williamwen42 Differential Revision: D52256752
This pull request was exported from Phabricator. Differential Revision: D52256752 |
1 similar comment
This pull request was exported from Phabricator. Differential Revision: D52256752 |
3c47eb3
to
0c4b233
Compare
Summary: This macro checks a macro in torch/library.h. We need to import torch.library.h first, otherwise we erroneously set the macro to nothing. Reviewed By: williamwen42 Differential Revision: D52256752
This pull request was exported from Phabricator. Differential Revision: D52256752 |
1 similar comment
This pull request was exported from Phabricator. Differential Revision: D52256752 |
Summary: It passes all tests. Reviewed By: williamwen42 Differential Revision: D52256116
Summary: It needed an abstract impl. Reviewed By: williamwen42 Differential Revision: D52256098
Summary: This macro checks a macro in torch/library.h. We need to import torch.library.h first, otherwise we erroneously set the macro to nothing. Reviewed By: williamwen42 Differential Revision: D52256752
0c4b233
to
e13f6eb
Compare
This pull request was exported from Phabricator. Differential Revision: D52256752 |
1 similar comment
This pull request was exported from Phabricator. Differential Revision: D52256752 |
This pull request has been merged in 9f426bb. |
Summary:
This macro checks a macro in torch/library.h.
We need to import torch.library.h first, otherwise we erroneously set the macro
to nothing.
Reviewed By: williamwen42
Differential Revision: D52256752