Fix run_tbe_benchmark.py so that it benchmarks all shapes supplied to it #2300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D53276155 |
excelle08
pushed a commit
to excelle08/FBGEMM
that referenced
this pull request
Feb 1, 2024
… it (pytorch#2300) Summary: Previously `run_tbe_benchmark.py` will only supply one bag size to the `--bag-size-list` parameter of split_table_batched_embeddings_benchmark. This will cause the benchmark to only run the first shape supplied to it. This diff fixes this bug by supplying N copies of bag_size to `--bag-size-list` parameter (N = number of shapes). Reviewed By: jspark1105 Differential Revision: D53276155
excelle08
force-pushed
the
export-D53276155
branch
from
c1b89af
to
7b73a72
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53276155 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D53276155 |
… it (pytorch#2300) Summary: Previously `run_tbe_benchmark.py` will only supply one bag size to the `--bag-size-list` parameter of split_table_batched_embeddings_benchmark. This will cause the benchmark to only run the first shape supplied to it. This diff fixes this bug by supplying N copies of bag_size to `--bag-size-list` parameter (N = number of shapes). Reviewed By: jspark1105 Differential Revision: D53276155
excelle08
pushed a commit
to excelle08/FBGEMM
that referenced
this pull request
Feb 1, 2024
… it (pytorch#2300) Summary: Previously `run_tbe_benchmark.py` will only supply one bag size to the `--bag-size-list` parameter of split_table_batched_embeddings_benchmark. This will cause the benchmark to only run the first shape supplied to it. This diff fixes this bug by supplying N copies of bag_size to `--bag-size-list` parameter (N = number of shapes). Reviewed By: jspark1105 Differential Revision: D53276155
excelle08
force-pushed
the
export-D53276155
branch
from
7b73a72
to
4f8c70b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53276155 |
excelle08
force-pushed
the
export-D53276155
branch
from
4f8c70b
to
ad759e7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53276155 |
|
This pull request has been merged in 50ecd52. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Previously
run_tbe_benchmark.pywill only supply one bag size to the--bag-size-listparameter of split_table_batched_embeddings_benchmark. This will cause the benchmark to only run the first shape supplied to it. This diff fixes this bug by supplying N copies of bag_size to--bag-size-listparameter (N = number of shapes).Reviewed By: jspark1105
Differential Revision: D53276155