-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix run_tbe_benchmark.py so that it benchmarks all shapes supplied to it #2300
Conversation
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This pull request was exported from Phabricator. Differential Revision: D53276155 |
… it (pytorch#2300) Summary: Previously `run_tbe_benchmark.py` will only supply one bag size to the `--bag-size-list` parameter of split_table_batched_embeddings_benchmark. This will cause the benchmark to only run the first shape supplied to it. This diff fixes this bug by supplying N copies of bag_size to `--bag-size-list` parameter (N = number of shapes). Reviewed By: jspark1105 Differential Revision: D53276155
c1b89af
to
7b73a72
Compare
This pull request was exported from Phabricator. Differential Revision: D53276155 |
1 similar comment
This pull request was exported from Phabricator. Differential Revision: D53276155 |
… it (pytorch#2300) Summary: Previously `run_tbe_benchmark.py` will only supply one bag size to the `--bag-size-list` parameter of split_table_batched_embeddings_benchmark. This will cause the benchmark to only run the first shape supplied to it. This diff fixes this bug by supplying N copies of bag_size to `--bag-size-list` parameter (N = number of shapes). Reviewed By: jspark1105 Differential Revision: D53276155
… it (pytorch#2300) Summary: Previously `run_tbe_benchmark.py` will only supply one bag size to the `--bag-size-list` parameter of split_table_batched_embeddings_benchmark. This will cause the benchmark to only run the first shape supplied to it. This diff fixes this bug by supplying N copies of bag_size to `--bag-size-list` parameter (N = number of shapes). Reviewed By: jspark1105 Differential Revision: D53276155
7b73a72
to
4f8c70b
Compare
This pull request was exported from Phabricator. Differential Revision: D53276155 |
4f8c70b
to
ad759e7
Compare
This pull request was exported from Phabricator. Differential Revision: D53276155 |
This pull request has been merged in 50ecd52. |
Summary: Previously
run_tbe_benchmark.py
will only supply one bag size to the--bag-size-list
parameter of split_table_batched_embeddings_benchmark. This will cause the benchmark to only run the first shape supplied to it. This diff fixes this bug by supplying N copies of bag_size to--bag-size-list
parameter (N = number of shapes).Reviewed By: jspark1105
Differential Revision: D53276155