Add int32 overflow unit test for TBE UVM caching #2303
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D53300526 |
sryap
added a commit
to sryap/FBGEMM
that referenced
this pull request
Feb 1, 2024
Summary: Pull Request resolved: pytorch#2303 This diff introduces a unit test to verify that TBE with UVM caching can handle the cache access correctly when the cache access offset is larger than max int32 Differential Revision: D53300526 fbshipit-source-id: aabbcc3bb376ac01ea7e0ae2b6cf37bb3be0be84
sryap
force-pushed
the
export-D53300526
branch
from
979ca20
to
9d0643d
Compare
Summary: Pull Request resolved: pytorch#2303 This diff introduces a unit test to verify that TBE with UVM caching can handle the cache access correctly when the cache access offset is larger than max int32 Differential Revision: D53300526 fbshipit-source-id: 5a73af9dfaee6d17167bba53d65868e9242d5c37
|
This pull request was exported from Phabricator. Differential Revision: D53300526 |
sryap
force-pushed
the
export-D53300526
branch
from
9d0643d
to
16d7573
Compare
|
This pull request has been merged in b347a43. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff introduces a unit test to verify that TBE with UVM caching
can handle the cache access correctly when the cache access offset is
larger than max int32
Differential Revision: D53300526