-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor stochastic rounding state in TBE #2312
Conversation
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This pull request was exported from Phabricator. Differential Revision: D53462989 |
Summary: This diff addresses an issue with `StochasticRoundingRNGState` where it was previously allocated inside a function but its address was accessed after the function had returned, leading to illegal memory access. To address this, the allocation of `StochasticRoundingRNGState` has been moved outside of the function to ensure that it remains alive for all accesses, preventing any illegal memory access issues. Differential Revision: D53462989
bf7b0db
to
4f5e446
Compare
This pull request was exported from Phabricator. Differential Revision: D53462989 |
4f5e446
to
50f1529
Compare
Summary: Pull Request resolved: pytorch#2312 This diff addresses an issue with `StochasticRoundingRNGState` where it was previously allocated inside a function but its address was accessed after the function had returned, leading to illegal memory access. To address this, the allocation of `StochasticRoundingRNGState` has been moved outside of the function to ensure that it remains alive for all accesses, preventing any illegal memory access issues. Differential Revision: D53462989 fbshipit-source-id: 6dafe5c2889e7723d044568383df1042ff91af79
Summary: This diff addresses an issue with `StochasticRoundingRNGState` where it was previously allocated inside a function but its address was accessed after the function had returned, leading to illegal memory access. To address this, the allocation of `StochasticRoundingRNGState` has been moved outside of the function to ensure that it remains alive for all accesses, preventing any illegal memory access issues. Differential Revision: D53462989
50f1529
to
07d1e6e
Compare
This pull request was exported from Phabricator. Differential Revision: D53462989 |
Summary: This diff addresses an issue with `StochasticRoundingRNGState` where it was previously allocated inside a function but its address was accessed after the function had returned, leading to illegal memory access. To address this, the allocation of `StochasticRoundingRNGState` has been moved outside of the function to ensure that it remains alive for all accesses, preventing any illegal memory access issues. Differential Revision: D53462989
07d1e6e
to
11bf633
Compare
This pull request was exported from Phabricator. Differential Revision: D53462989 |
Summary: This diff addresses an issue with `StochasticRoundingRNGState` where it was previously allocated inside a function but its address was accessed after the function had returned, leading to illegal memory access. To address this, the allocation of `StochasticRoundingRNGState` has been moved outside of the function to ensure that it remains alive for all accesses, preventing any illegal memory access issues. Reviewed By: jspark1105 Differential Revision: D53462989
11bf633
to
f9eb38d
Compare
This pull request was exported from Phabricator. Differential Revision: D53462989 |
Summary: This diff addresses an issue with `StochasticRoundingRNGState` where it was previously allocated inside a function but its address was accessed after the function had returned, leading to illegal memory access. To address this, the allocation of `StochasticRoundingRNGState` has been moved outside of the function to ensure that it remains alive for all accesses, preventing any illegal memory access issues. Reviewed By: jspark1105 Differential Revision: D53462989
This pull request has been merged in 8664c84. |
Summary:
This diff addresses an issue with
StochasticRoundingRNGState
whereit was previously allocated inside a function but its address was
accessed after the function had returned, leading to illegal memory
access. To address this, the allocation of
StochasticRoundingRNGState
has been moved outside of the function toensure that it remains alive for all accesses, preventing any illegal
memory access issues.
Differential Revision: D53462989