Refactor stochastic rounding state in TBE #2312
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D53462989 |
sryap
added a commit
to sryap/FBGEMM
that referenced
this pull request
Feb 6, 2024
Summary: This diff addresses an issue with `StochasticRoundingRNGState` where it was previously allocated inside a function but its address was accessed after the function had returned, leading to illegal memory access. To address this, the allocation of `StochasticRoundingRNGState` has been moved outside of the function to ensure that it remains alive for all accesses, preventing any illegal memory access issues. Differential Revision: D53462989
sryap
force-pushed
the
export-D53462989
branch
from
bf7b0db
to
4f5e446
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53462989 |
sryap
force-pushed
the
export-D53462989
branch
from
4f5e446
to
50f1529
Compare
sryap
added a commit
to sryap/FBGEMM
that referenced
this pull request
Feb 7, 2024
Summary: Pull Request resolved: pytorch#2312 This diff addresses an issue with `StochasticRoundingRNGState` where it was previously allocated inside a function but its address was accessed after the function had returned, leading to illegal memory access. To address this, the allocation of `StochasticRoundingRNGState` has been moved outside of the function to ensure that it remains alive for all accesses, preventing any illegal memory access issues. Differential Revision: D53462989 fbshipit-source-id: 6dafe5c2889e7723d044568383df1042ff91af79
sryap
added a commit
to sryap/FBGEMM
that referenced
this pull request
Feb 7, 2024
Summary: This diff addresses an issue with `StochasticRoundingRNGState` where it was previously allocated inside a function but its address was accessed after the function had returned, leading to illegal memory access. To address this, the allocation of `StochasticRoundingRNGState` has been moved outside of the function to ensure that it remains alive for all accesses, preventing any illegal memory access issues. Differential Revision: D53462989
sryap
force-pushed
the
export-D53462989
branch
from
50f1529
to
07d1e6e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53462989 |
sryap
added a commit
to sryap/FBGEMM
that referenced
this pull request
Feb 7, 2024
Summary: This diff addresses an issue with `StochasticRoundingRNGState` where it was previously allocated inside a function but its address was accessed after the function had returned, leading to illegal memory access. To address this, the allocation of `StochasticRoundingRNGState` has been moved outside of the function to ensure that it remains alive for all accesses, preventing any illegal memory access issues. Differential Revision: D53462989
sryap
force-pushed
the
export-D53462989
branch
from
07d1e6e
to
11bf633
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53462989 |
Summary: This diff addresses an issue with `StochasticRoundingRNGState` where it was previously allocated inside a function but its address was accessed after the function had returned, leading to illegal memory access. To address this, the allocation of `StochasticRoundingRNGState` has been moved outside of the function to ensure that it remains alive for all accesses, preventing any illegal memory access issues. Reviewed By: jspark1105 Differential Revision: D53462989
sryap
force-pushed
the
export-D53462989
branch
from
11bf633
to
f9eb38d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53462989 |
sryap
added a commit
to sryap/FBGEMM
that referenced
this pull request
Feb 8, 2024
Summary: This diff addresses an issue with `StochasticRoundingRNGState` where it was previously allocated inside a function but its address was accessed after the function had returned, leading to illegal memory access. To address this, the allocation of `StochasticRoundingRNGState` has been moved outside of the function to ensure that it remains alive for all accesses, preventing any illegal memory access issues. Reviewed By: jspark1105 Differential Revision: D53462989
|
This pull request has been merged in 8664c84. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff addresses an issue with
StochasticRoundingRNGStatewhereit was previously allocated inside a function but its address was
accessed after the function had returned, leading to illegal memory
access. To address this, the allocation of
StochasticRoundingRNGStatehas been moved outside of the function toensure that it remains alive for all accesses, preventing any illegal
memory access issues.
Differential Revision: D53462989