remove d2h sync from keyed jagged index select #2315
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D53461566 |
joshuadeng
added a commit
to joshuadeng/FBGEMM
that referenced
this pull request
Feb 7, 2024
Summary: Add option to provide output length for values if known to avoid D to H sync. For permutation cases using keyed jagged index select where batch size. == len(lengths), the output length will be known to be len(values). Reviewed By: sryap Differential Revision: D53461566
joshuadeng
force-pushed
the
export-D53461566
branch
from
89db799
to
e73e0a1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53461566 |
joshuadeng
added a commit
to joshuadeng/FBGEMM
that referenced
this pull request
Feb 7, 2024
Summary: Add option to provide output length for values if known to avoid D to H sync. For permutation cases using keyed jagged index select where batch size. == len(lengths), the output length will be known to be len(values). Reviewed By: sryap Differential Revision: D53461566
joshuadeng
force-pushed
the
export-D53461566
branch
from
e73e0a1
to
284ee7a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53461566 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D53461566 |
Summary: Pull Request resolved: pytorch#2315 Add option to provide output length for values if known to avoid D to H sync. For permutation cases using keyed jagged index select where batch size. == len(lengths), the output length will be known to be len(values). Reviewed By: sryap Differential Revision: D53461566 fbshipit-source-id: 1f88f5f5dbe367acb0a4c115b3bd3e8cb42c7e62
|
This pull request was exported from Phabricator. Differential Revision: D53461566 |
joshuadeng
force-pushed
the
export-D53461566
branch
from
284ee7a
to
c327fca
Compare
|
This pull request has been merged in e80d507. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Add option to provide output length for values if known to avoid D to H sync. For permutation cases using keyed jagged index select where batch size. == len(lengths), the output length will be known to be len(values).
Differential Revision: D53461566