TBE logging - improve cache print format #2379
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D54181314 |
added 3 commits
March 4, 2024 22:59
Summary: Make it possible to interpret TBE logs when there are multiple TBEs on a rank. This diff (1) prints the table names contained in a TBE, (2) prefixes all TBE logging with a unique id per TBE instance. We use a uuid, so when there are many TBEs across many ranks, they will all be unique. Reviewed By: carlbunny, henrylhtsang Differential Revision: D54181313
…2378) Summary: When 'training.tbe.gather_uvm_cache_stats=True', always log UVM cache activity. We decrease logging frequency using an exponential schedule as training proceeds. This keeps log overhead minimal while still providing insight into whether cache hit rates become non-stationary over large training periods. Reviewed By: sryap Differential Revision: D54181312
Summary: Improve uvm cache printing format, now single line & easily machine-parseable. Differential Revision: D54181314
damianr99
force-pushed
the
export-D54181314
branch
from
89cedf3
to
2d58ddc
Compare
damianr99
pushed a commit
to damianr99/FBGEMM
that referenced
this pull request
Mar 5, 2024
Summary: Improve uvm cache printing format, now single line & easily machine-parseable. Differential Revision: D54181314
|
This pull request was exported from Phabricator. Differential Revision: D54181314 |
damianr99
force-pushed
the
export-D54181314
branch
from
2d58ddc
to
0cdeded
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54181314 |
|
This pull request has been merged in af9abb5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Improve uvm cache printing format, now single line & easily machine-parseable.
Differential Revision: D54181314