Skip prefetch/cache mutations for dynamo #2514
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D56303894 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Summary: Dynamo NNModule attributes mutation forces Dynamo to restart Analysis, which regresses compilation time. Those mutations are used for prefetching/caching that we do not need for dynamo tracing. Differential Revision: D56303894
IvanKobzarev
force-pushed
the
export-D56303894
branch
from
8ad0085
to
00bbb28
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56303894 |
|
This pull request has been merged in aa74aaa. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Dynamo NNModule attributes mutation forces Dynamo to restart Analysis, which regresses compilation time.
Those mutations are used for prefetching/caching that we do not need for dynamo tracing.
Differential Revision: D56303894