Implement offseted mode for linearize_cache_indices CUDA kernel #2554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This patch will allow base_offset as a parameter so all values in `offset` will be decresed by that amount. This is done in a way that no copy of `offset`. The ultimate goal for this is to achieve multipass prefetch, which require calling this kernel on a segment of `indices` (rather than the whole). See unittest for its usage. Differential Revision: D56863774
|
This pull request was exported from Phabricator. Differential Revision: D56863774 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
levythu
added a commit
to levythu/FBGEMM
that referenced
this pull request
May 7, 2024
…h#2554) Summary: This patch will allow base_offset as a parameter so all values in `offset` will be decresed by that amount. This is done in a way that no copy of `offset`. The ultimate goal for this is to achieve multipass prefetch, which require calling this kernel on a segment of `indices` (rather than the whole). See unittest for its usage. Reviewed By: SherlockNoMad, henryoier Differential Revision: D56863774
levythu
added a commit
to levythu/FBGEMM
that referenced
this pull request
May 7, 2024
…h#2554) Summary: This patch will allow base_offset as a parameter so all values in `offset` will be decresed by that amount. This is done in a way that no copy of `offset`. The ultimate goal for this is to achieve multipass prefetch, which require calling this kernel on a segment of `indices` (rather than the whole). See unittest for its usage. Reviewed By: SherlockNoMad, henryoier Differential Revision: D56863774
|
This pull request has been merged in 254aa96. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This patch will allow base_offset as a parameter so all values in
offsetwill be decresed by that amount. This is done in a way that no copy ofoffset.The ultimate goal for this is to achieve multipass prefetch, which require calling this kernel on a segment of
indices(rather than the whole). See unittest for its usage.Differential Revision: D56863774