Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FP16 weight and output support #2638

Closed
wants to merge 2 commits into from
Closed

Conversation

sryap
Copy link
Contributor

@sryap sryap commented May 29, 2024

Summary:
This diff adds FP16 weight and output type support in SSD TBE.
Changes include:

  • Add weights_precision and output_dtype options in
    SSDTableBatchedEmbeddingBags
  • Update SSD Initializer to support FP16 weight
  • Update SSD TBE unit tests to validate FP16 weight and output

Differential Revision: D56578193

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56578193

Copy link

netlify bot commented May 29, 2024

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit 2b649cc
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/6658b4445c1e0c00082cf256
😎 Deploy Preview https://deploy-preview-2638--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sryap added a commit to sryap/FBGEMM that referenced this pull request May 29, 2024
Summary:

This diff adds FP16 weight and output type support in SSD TBE.
Changes include:

- Add `weights_precision` and `output_dtype` options in
  `SSDTableBatchedEmbeddingBags`
- Update SSD `Initializer` to support FP16 weight
- Update SSD TBE unit tests to validate FP16 weight and output

Differential Revision: D56578193
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56578193

sryap added a commit to sryap/FBGEMM that referenced this pull request May 29, 2024
Summary:

This diff adds FP16 weight and output type support in SSD TBE.
Changes include:

- Add `weights_precision` and `output_dtype` options in
  `SSDTableBatchedEmbeddingBags`
- Update SSD `Initializer` to support FP16 weight
- Update SSD TBE unit tests to validate FP16 weight and output

Differential Revision: D56578193
sryap added a commit to sryap/FBGEMM that referenced this pull request May 29, 2024
Summary:

This diff adds FP16 weight and output type support in SSD TBE.
Changes include:

- Add `weights_precision` and `output_dtype` options in
  `SSDTableBatchedEmbeddingBags`
- Update SSD `Initializer` to support FP16 weight
- Update SSD TBE unit tests to validate FP16 weight and output

Differential Revision: D56578193
sryap added a commit to sryap/FBGEMM that referenced this pull request May 29, 2024
Summary:

This diff adds FP16 weight and output type support in SSD TBE.
Changes include:

- Add `weights_precision` and `output_dtype` options in
  `SSDTableBatchedEmbeddingBags`
- Update SSD `Initializer` to support FP16 weight
- Update SSD TBE unit tests to validate FP16 weight and output

Differential Revision: D56578193
sryap added a commit to sryap/FBGEMM that referenced this pull request May 29, 2024
Summary:

This diff adds FP16 weight and output type support in SSD TBE.
Changes include:

- Add `weights_precision` and `output_dtype` options in
  `SSDTableBatchedEmbeddingBags`
- Update SSD `Initializer` to support FP16 weight
- Update SSD TBE unit tests to validate FP16 weight and output

Differential Revision: D56578193
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56578193

sryap added a commit to sryap/FBGEMM that referenced this pull request May 30, 2024
Summary:
Pull Request resolved: pytorch#2638

This diff adds FP16 weight and output type support in SSD TBE.
Changes include:

- Add `weights_precision` and `output_dtype` options in
  `SSDTableBatchedEmbeddingBags`
- Update SSD `Initializer` to support FP16 weight
- Update SSD TBE unit tests to validate FP16 weight and output

Reviewed By: henrylhtsang

Differential Revision: D56578193
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56578193

sryap added a commit to sryap/FBGEMM that referenced this pull request May 30, 2024
Summary:
Pull Request resolved: pytorch#2638

This diff adds FP16 weight and output type support in SSD TBE.
Changes include:

- Add `weights_precision` and `output_dtype` options in
  `SSDTableBatchedEmbeddingBags`
- Update SSD `Initializer` to support FP16 weight
- Update SSD TBE unit tests to validate FP16 weight and output

Reviewed By: henrylhtsang

Differential Revision: D56578193
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56578193

sryap added a commit to sryap/FBGEMM that referenced this pull request May 30, 2024
Summary:
Pull Request resolved: pytorch#2638

This diff adds FP16 weight and output type support in SSD TBE.
Changes include:

- Add `weights_precision` and `output_dtype` options in
  `SSDTableBatchedEmbeddingBags`
- Update SSD `Initializer` to support FP16 weight
- Update SSD TBE unit tests to validate FP16 weight and output

Reviewed By: henrylhtsang

Differential Revision: D56578193
Summary:
Pull Request resolved: pytorch#2638

This diff adds FP16 weight and output type support in SSD TBE.
Changes include:

- Add `weights_precision` and `output_dtype` options in
  `SSDTableBatchedEmbeddingBags`
- Update SSD `Initializer` to support FP16 weight
- Update SSD TBE unit tests to validate FP16 weight and output

Reviewed By: henrylhtsang

Differential Revision: D56578193
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56578193

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 5f9f877.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants