Fix Windows shared build #268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jspark1105
reviewed
Jan 23, 2020
shz0116
approved these changes
Jan 23, 2020
There was a problem hiding this comment.
@shz0116 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@shz0116 I guess this PR is not needed anymore, right? |
|
@peterjc123 Thanks for the help. I once tried to import your changes directly into the codes, but messed up with other changes. Now, your changes are reflected in different PRs. Also, I made some changes recently for Windows build, both static and dynamic, Debug and Release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested locally with