Improve MX4 perf Pt. 1 #2709
Closed
Improve MX4 perf Pt. 1 #2709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D58296469 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D58296469 |
spcyppt
added a commit
that referenced
this pull request
Jun 11, 2024
Summary: Pull Request resolved: #2709 This kernel is compute bound when the input tensor is very large. One of the factors and the main optimization for this diff is doing a fusion instruction. That is, instead of doing `x * pow(2, y)`, we do `scalebn(x, y)` -- this significantly reduces the number of cycles needed to do the computation. Improve MX4 kernel performance - replace `pow` with `scalebn` - remove `flush_fp32_subnorms` which is currently not used. (Note: we will update to support this later) Performance improvement: - quantize: 39M cycles -> 24M - dequantize: 28M -> 10M Reviewed By: sryap Differential Revision: D58296469
spcyppt
force-pushed
the
export-D58296469
branch
from
d5448a1
to
488cde7
Compare
Summary: Pull Request resolved: #2709 This kernel is compute bound when the input tensor is very large. One of the factors and the main optimization for this diff is doing a fusion instruction. That is, instead of doing `x * pow(2, y)`, we do `scalebn(x, y)` -- this significantly reduces the number of cycles needed to do the computation. Improve MX4 kernel performance - replace `pow` with `scalebn` - remove `flush_fp32_subnorms` which is currently not used. (Note: we will update to support this later) Performance improvement: - quantize: 39M cycles -> 24M - dequantize: 28M -> 10M Reviewed By: sryap Differential Revision: D58296469
|
This pull request was exported from Phabricator. Differential Revision: D58296469 |
spcyppt
force-pushed
the
export-D58296469
branch
from
488cde7
to
d24b546
Compare
|
This pull request has been merged in d8900ae. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This kernel is compute bound when the input tensor is very large. One of the factors and the main optimization for this diff is doing a fusion instruction. That is, instead of doing
x * pow(2, y), we doscalebn(x, y)-- this significantly reduces the number of cycles needed to do the computation.Improve MX4 kernel performance
powwithscalebnflush_fp32_subnormswhich is currently not used. (Note: we will update to support this later)Performance improvement:
Reviewed By: sryap
Differential Revision: D58296469