-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make mypy linting be more consistent with core and fix lints #591
Conversation
[ghstack-poisoned]
[ghstack-poisoned]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a thousand for aligning Tau with PyTorch!
I submitted a PR #594 to fix the final lint other than those silenced ones.
@wanchaol can I land this one? Any concern? |
There're a bunch of ci failures, I need to resolve them before landing, do you need this soon? If so, I'll try to fix them soon and land it |
I see, no hurry, please take your time. |
[ghstack-poisoned]
[ghstack-poisoned]
check.sh
Outdated
@@ -65,7 +65,7 @@ flake8 pippy spmd test/spmd | |||
|
|||
# mypy spmd test/spmd | |||
echo; echo "Running mypy ..." | |||
mypy spmd pippy test examples | |||
mypy spmd pippy examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kwen2501 after restricting more mypy linting with pytorch, there emerges tons of failures in tests, imo we shouldn't require strong type annotation in tests as that will slow down the dev efficiency, let me know if this not look good to you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might also stay true for examples? I am changing mypy to only run under pippy
and spmd
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
ghstack-source-id: 35301cff60c9a260f72e008f29a49fc8a785f2e4 Pull Request resolved: #591
Stack from ghstack (oldest at bottom):