Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create some sort of serialization / deserialization functionality #40

Closed
narendasan opened this issue Apr 22, 2020 · 1 comment · Fixed by #74
Closed

Create some sort of serialization / deserialization functionality #40

narendasan opened this issue Apr 22, 2020 · 1 comment · Fixed by #74
Labels
component: core Issues re: The core compiler feature request New feature or request priority: high
Projects
Milestone

Comments

@narendasan
Copy link
Collaborator

With INT8 about to land, would be a pain to have to calibrate from scratch every time. There should be some mechanism to save and load modules with the TRT engine included.

@narendasan narendasan added feature request New feature or request component: core Issues re: The core compiler priority: high labels Apr 22, 2020
@salexspb
Copy link

salexspb commented Apr 23, 2020

That would be awesome to have proper serialization! I would also add that for large scale deployments this is a must have even for fp16. As if you have a lot of models, converting all of them on restart would be quite expensive. And in general in some systems doing tuning in production is generally undesirable.

@narendasan narendasan added this to the v0.1.0 milestone Apr 25, 2020
@narendasan narendasan added this to To do in TRTorch May 18, 2020
TRTorch automation moved this from To do to Done May 31, 2020
frank-wei pushed a commit that referenced this issue Jun 4, 2022
Summary:
Pull Request resolved: pytorch/fx2trt#40

add support for torch.nn.functional.conv_transpose3d

Reviewed By: 842974287

Differential Revision: D35176171

fbshipit-source-id: 5b10fba4568ad9fb26203f3dd396e13a98bc3495
mfeliz-cruise added a commit to mfeliz-cruise/Torch-TensorRT that referenced this issue Aug 23, 2022
Adds a heuristic to torch-trt partitioning's segmentation to avoid materializing segments until we hit a dependency of that segment. This can significantly reduce the number of segments/engines in cases where the linear traversal of torchscipt nodes would otherwise produce alternating torch and TRT segments which are not dependent on each-other

Fixes # (issue)

Please delete options that are not relevant and/or add your own.

- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
- This change requires a documentation update

- [ ] My code follows the style guidelines of this project (You can use the linters)
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas and hacks
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests to verify my fix or my feature
- [ ] New and existing unit tests pass locally with my changes
- [ ] I have added the relevant labels to my PR in so that relevant reviewers are notified
mfeliz-cruise added a commit to mfeliz-cruise/Torch-TensorRT that referenced this issue Oct 6, 2022
Adds a heuristic to torch-trt partitioning's segmentation to avoid materializing segments until we hit a dependency of that segment. This can significantly reduce the number of segments/engines in cases where the linear traversal of torchscipt nodes would otherwise produce alternating torch and TRT segments which are not dependent on each-other

Fixes # (issue)

Please delete options that are not relevant and/or add your own.

- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
- This change requires a documentation update

- [ ] My code follows the style guidelines of this project (You can use the linters)
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas and hacks
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests to verify my fix or my feature
- [ ] New and existing unit tests pass locally with my changes
- [ ] I have added the relevant labels to my PR in so that relevant reviewers are notified
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: core Issues re: The core compiler feature request New feature or request priority: high
Projects
TRTorch
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants