Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add the explanation for partition phases on docs #1090

Merged
merged 1 commit into from
Jun 22, 2022
Merged

doc: add the explanation for partition phases on docs #1090

merged 1 commit into from
Jun 22, 2022

Conversation

bowang007
Copy link
Collaborator

@bowang007 bowang007 commented May 26, 2022 •
edited

Signed-off-by: Bo Wang bowa@nvidia.com

Description

Documentation for partitioning.

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes

@bowang007
doc: add the explanation for partition phases on docs
41dd042 
Signed-off-by: Bo Wang <bowa@nvidia.com>
@bowang007 bowang007 requested a review from narendasan May 26, 2022 01:05
@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 26, 2022
github-actions[bot]
github-actions bot approved these changes May 26, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes May 26, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes May 26, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes May 26, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

narendasan
narendasan reviewed May 27, 2022
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any details from #360 that we want to include here?

@narendasan narendasan merged commit 89f631b into master Jun 22, 2022
@narendasan narendasan deleted the partitioning_documentation branch June 22, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan left review comments

@github-actions github-actions[bot] github-actions approved these changes

Assignees
No one assigned
Labels
cla signed documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bowang007 @narendasan @facebook-github-bot