Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the internal codebase from fx2trt_oss to torch_tensorrt #1104

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

frank-wei
Copy link
Contributor

@frank-wei frank-wei commented Jun 8, 2022

364639a8ab2ee7531ce5259b8985a3c90bda4fdf Wei Wei wwei6@fb.com [fx2trt] target files added
07d8e842b54b9c727f4215239f6c007cc7a62c9f Wei Wei wwei6@fb.com Swap fx2trt_oss to torch_tensorrt

Description

This PR is for changing import path by removing any fx2trt_oss and replace with torch_tensorrt.
Also internal linter/formatter is applied.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

364639a8ab2ee7531ce5259b8985a3c90bda4fdf Wei Wei <wwei6@fb.com> [fx2trt] target files added
07d8e842b54b9c727f4215239f6c007cc7a62c9f Wei Wei <wwei6@fb.com> Swap fx2trt_oss to torch_tensorrt
@github-actions github-actions bot added component: api [Python] Issues re: Python API documentation Improvements or additions to documentation labels Jun 8, 2022
@github-actions github-actions bot requested a review from narendasan June 8, 2022 20:01
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

@frank-wei frank-wei changed the title Changes done internally at Facebook Refactor the internal codebase from fx2trt_oss to torch_tensorrt Jun 8, 2022
Copy link

@yinghai yinghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe we should begin check linting.

@frank-wei frank-wei merged commit fa33de2 into master Jun 8, 2022
@frank-wei frank-wei deleted the fb-sync-2-wwei6 branch June 9, 2022 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: api [Python] Issues re: Python API component: fx documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants