Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: support slice with dynamic shape #1110

Merged
merged 10 commits into from
Jul 15, 2022
Merged

Conversation

inocsin
Copy link
Contributor

@inocsin inocsin commented Jun 13, 2022

Signed-off-by: inocsin vcheungyi@163.com

Description

Support aten::slice with dynamic shape

Fixes #945 #1087

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

Signed-off-by: inocsin <vcheungyi@163.com>
@github-actions github-actions bot added component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: tests Issues re: Tests labels Jun 13, 2022
@inocsin
Copy link
Contributor Author

inocsin commented Jun 13, 2022

@narendasan please review this PR

core/conversion/converters/converter_util.cpp Outdated Show resolved Hide resolved
core/conversion/converters/converter_util.cpp Outdated Show resolved Hide resolved
core/conversion/converters/converter_util.cpp Outdated Show resolved Hide resolved
core/conversion/converters/converter_util.cpp Outdated Show resolved Hide resolved
core/conversion/converters/converter_util.cpp Outdated Show resolved Hide resolved
Signed-off-by: inocsin <vcheungyi@163.com>
Signed-off-by: inocsin <vcheungyi@163.com>
Signed-off-by: inocsin <vcheungyi@163.com>
@inocsin
Copy link
Contributor Author

inocsin commented Jun 29, 2022

@narendasan updated the code

@ncomly-nvidia ncomly-nvidia added the release: v1.2 Tagged to be included in v1.2 label Jul 11, 2022
@github-actions github-actions bot requested a review from narendasan July 11, 2022 20:58
core/conversion/converters/converter_util.cpp Outdated Show resolved Hide resolved
core/conversion/converters/converter_util.cpp Outdated Show resolved Hide resolved
Signed-off-by: inocsin <vcheungyi@163.com>
core/conversion/converters/converter_util.cpp Outdated Show resolved Hide resolved
core/conversion/converters/converter_util.cpp Outdated Show resolved Hide resolved
core/conversion/converters/converter_util.cpp Outdated Show resolved Hide resolved
Signed-off-by: inocsin <vcheungyi@163.com>
@peri044 peri044 merged commit d3041f5 into pytorch:master Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: tests Issues re: Tests release: v1.2 Tagged to be included in v1.2
Projects
None yet
6 participants