Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fx_acc] Add acc_tracer support for torch.mm #1120

Merged
merged 1 commit into from
Jun 15, 2022
Merged

[fx_acc] Add acc_tracer support for torch.mm #1120

merged 1 commit into from
Jun 15, 2022

Conversation

khabinov
Copy link
Contributor

@khabinov khabinov commented Jun 15, 2022 •
edited

fe350dcc4d6ff19c76191fcf3690349eaf9dfaa7 Oleg Khabinov khabinov@fb.com [fx_acc] Add acc_tracer support for torch.mm

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@khabinov
Changes done internally at Facebook
d897a0a 
364639a8ab2ee7531ce5259b8985a3c90bda4fdf Wei Wei <wwei6@fb.com> [fx2trt] target files added
07d8e842b54b9c727f4215239f6c007cc7a62c9f Wei Wei <wwei6@fb.com> Swap fx2trt_oss to torch_tensorrt
74731c90fd63e41ff5997887d8f72ca0b805cf8d Yinghai Lu <yinghai@fb.com> Fix uru_10x10 test
6c53d36a08a7d465a1108d7154ef29a373eb38cc Wei Wei <wwei6@fb.com> [fx2trt] Modify lower setting class to accommandate AIT lowering
6f873f4f3ece9d476479eb7c9633d38554dd8692 Oleg Khabinov <khabinov@fb.com> [fx2trt] Make sure acc_tracer belongs only to single target
529a5750ace2bede6e9b7a9922a0f75c459df16b Shirong Wu <shirong@fb.com> Enable explicit batch dim for MTS gpu benchmark
2d284df94ddb530f3a8875fdc76796fad508ec29 Wei Wei <wwei6@fb.com> [fx2trt] remove wildcard for obj of torch_fx2trt in TARGETS
84b53b15427cc08fb1e36143b6bdec4557f50d7e Shirong Wu <shirong@fb.com> Add var converter
17e309b17b3ba66cda0e7d5712089d860a5e125e Jordan Fix <jfix@fb.com> [const_fold] Set requires_grad based on the folded tensor; add device_for_folding option
2c8f1b23be30ec968ad27215256d250c872616b0 Kefei Lu <kefeilu@fb.com> lowering: support creating lowerer instance with "presets"
fe350dcc4d6ff19c76191fcf3690349eaf9dfaa7 Oleg Khabinov <khabinov@fb.com> [fx_acc] Add acc_tracer support for torch.mm
frank-wei
frank-wei approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@frank-wei frank-wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

github-actions[bot]
github-actions bot approved these changes Jun 15, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

@khabinov khabinov changed the title Changes done internally at Facebook [fx_acc] Add acc_tracer support for torch.mm Jun 15, 2022
@frank-wei frank-wei merged commit c558de8 into master Jun 15, 2022
@frank-wei frank-wei deleted the fb-sync-khabinov branch June 15, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yinghai yinghai yinghai approved these changes

@frank-wei frank-wei frank-wei approved these changes

@github-actions github-actions[bot] github-actions approved these changes

@842974287 842974287 Awaiting requested review from 842974287

@narendasan narendasan Awaiting requested review from narendasan

@wushirong wushirong Awaiting requested review from wushirong

Assignees
No one assigned
Labels
cla signed component: api [Python] Issues re: Python API component: fx fx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@khabinov @yinghai @frank-wei @facebook-github-bot