Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update release branch #1348

Merged
merged 57 commits into from
Sep 12, 2022
Merged

Update release branch #1348

merged 57 commits into from
Sep 12, 2022

Conversation

narendasan
Copy link
Collaborator

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

dheerajperi and others added 30 commits May 31, 2022 12:00
@dheerajperi
chore: additional options for perf_run tool
46961d9 
Signed-off-by: dperi <dperi@nvidia.com>
@peri044
Merge branch 'master' into perf_changes
a13607a
@peri044
feat: Add fx2trt backend and revamp current perf utility to accept CL…
7779b50 
…I arguments

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@peri044
Merge branch 'master' into perf_changes
6cbf600
@peri044
chore: Refactor fx2trt functionality
d108f87 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@peri044
chore: Fix fp16 functionality for fx2trt backend
e92a813 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@peri044
chore: rebase
6a98dec 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@peri044
chore: refactor
2925c8a 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@peri044
chore: minor change
46d0e86 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@peri044
refactor: Refactor perf_run and add internal benchmark scripts
f8285ba 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@peri044
Merge branch 'master' into perf_changes
7461a24
@peri044
chore : minor refactor
561c339 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@peri044
Merge branch 'master' into perf_changes
66573fc
@peri044
chore: Apply precommit tooling
5bf2f4a 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@peri044
chore: Fix data loader issues and nox file paths
dd3af24 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@peri044
chore: Fix merge conflicts
bfae556 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@peri044
chore: rebase and minor changes
3a14f23 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@peri044
chore: Fix reporting to a file setting
d5dbc4d 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
Update lower.py (#1324)
e374eb1
docs: [Automated] Regenerating documenation for e374eb1
2c55974 
Signed-off-by: Torch-TensorRT Github Bot <torch-tensorrt.github.bot@nvidia.com>
@peri044
refactor: Refactor testing to use cosine similarity, remove redundanc…
5756169 
…y models and restructuring

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@peri044
chore: move to cosine similarity comparison
c6f3103 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@peri044
refactor: Refactor nox file testing
beeac7c 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@peri044
chore: add missing scripts
7e6b36c 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@peri044
chore: Linter fixes
ed75e9d 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@andi4191
fix!: Fixed Windows compilation failures
7245727 
Signed-off-by: Anurag Dixit <a.dixit91@gmail.com>
@narendasan
Merge pull request #1330 from pytorch/anuragd/fix_windows_compilation
a1a4786
@peri044
chore: Minor fix
3da78e9 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
@peri044
chore: use rn18 instead of rn50
0ca049f 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
docs: [Automated] Regenerating documenation for a1a4786
2af5942 
Signed-off-by: Torch-TensorRT Github Bot <torch-tensorrt.github.bot@nvidia.com>
Torch-TensorRT Github Bot and others added 9 commits September 8, 2022 22:46
docs: [Automated] Regenerating documenation for 096fd41
5f4588e 
Signed-off-by: Torch-TensorRT Github Bot <torch-tensorrt.github.bot@nvidia.com>
Update getting_started_with_fx_path.rst (#1342)
81cded1
docs: [Automated] Regenerating documenation for 81cded1
f0735f9 
Signed-off-by: Torch-TensorRT Github Bot <torch-tensorrt.github.bot@nvidia.com>
Update getting_started_with_fx_path.rst (#1343)
417efd2
docs: [Automated] Regenerating documenation for 417efd2
837a85c 
Signed-off-by: Torch-TensorRT Github Bot <torch-tensorrt.github.bot@nvidia.com>
enable direct call to fx.compile() (#1344)
450c869 
* enable direct call to fx.compile()

* Update lower_example.py

* Update _compile.py
docs: [Automated] Regenerating documenation for 450c869
3ef7909 
Signed-off-by: Torch-TensorRT Github Bot <torch-tensorrt.github.bot@nvidia.com>
@bowang007 @narendasan
fix: add remove_exception pass from torch to fix uninitialized tensor… (
63aa688 
#1345)

* fix: add remove_exception pass from torch to fix uninitialized tensor bug

Signed-off-by: Bo Wang <bowa@nvidia.com>

* chore: apply linting

Signed-off-by: Naren Dasan <naren@narendasan.com>
Signed-off-by: Naren Dasan <narens@nvidia.com>

Signed-off-by: Bo Wang <bowa@nvidia.com>
Signed-off-by: Naren Dasan <naren@narendasan.com>
Signed-off-by: Naren Dasan <narens@nvidia.com>
Co-authored-by: Naren Dasan <naren@narendasan.com>
@narendasan
chore: apply linting to docs (#1347)
87a639f 
Signed-off-by: Naren Dasan <naren@narendasan.com>
Signed-off-by: Naren Dasan <narens@nvidia.com>

Signed-off-by: Naren Dasan <naren@narendasan.com>
Signed-off-by: Naren Dasan <narens@nvidia.com>
@github-actions github-actions bot added component: api [Python] Issues re: Python API component: api [C++] Issues re: C++ API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: fx component: lowering Issues re: The lowering / preprocessing passes component: partitioning component: tests Issues re: Tests documentation Improvements or additions to documentation labels Sep 12, 2022
@narendasan narendasan merged commit 4cf44f2 into release/1.2 Sep 12, 2022
andi4191
andi4191 approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@andi4191 andi4191 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions about nox sessions

docsrc/tutorials/getting_started_with_fx_path.rst
@@ -56,7 +92,7 @@ Explicit batch is the default mode and it must be set for dynamic shape. For mos

For examples of the last path, if we have a 3D tensor t shaped as (batch, sequence, dimension), operations such as torch.transpose(0, 2). If any of these three are not satisfied, we’ll need to specify InputTensorSpec as inputs with dynamic range.

.. code-block:: shell
c
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@narendasan: Is this a typo?

noxfile.py
@@ -63,31 +66,6 @@ def install_torch_trt(session):
session.run("python", "setup.py", "develop")


def download_datasets(session):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@narendasan @peri044 : Why are we dropping download_datasets in nox?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was changed as part of @peri044's cos similarity overhaul

noxfile.py


@nox.session(python=SUPPORTED_PYTHON_VERSIONS, reuse_venv=True)
def download_test_models(session):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are the models downloaded in nox now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andi4191 andi4191 andi4191 approved these changes

@842974287 842974287 Awaiting requested review from 842974287

@bowang007 bowang007 Awaiting requested review from bowang007

@frank-wei frank-wei Awaiting requested review from frank-wei

@peri044 peri044 Awaiting requested review from peri044

@wushirong wushirong Awaiting requested review from wushirong

@yinghai yinghai Awaiting requested review from yinghai

Assignees
No one assigned
Labels
cla signed component: api [C++] Issues re: C++ API component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: fx component: lowering Issues re: The lowering / preprocessing passes component: partitioning component: tests Issues re: Tests documentation Improvements or additions to documentation fx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@narendasan @andi4191 @lixiaolx @facebook-github-bot @dheerajperi @peri044 @mfeliz-cruise @bowang007