[feat] Add partial converter support for aten::linalg_norm #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: conversion
github-actions
bot
requested review from
andi4191,
bowang007,
narendasan and
peri044
narendasan
reviewed
Nov 3, 2022
| auto self = args[0].ITensorOrFreeze(ctx); | ||
| TORCHTRT_CHECK( | ||
| args[1].IValue()->isNone(), | ||
| "aten::linalg_norm converter does not yet support non-None 'ord' arguments."); |
There was a problem hiding this comment.
Can we add a recommendation to add aten::linalg_norm to torch_executed_ops in this case?
mfeliz-cruise
requested review from
narendasan
and removed request for
peri044,
andi4191 and
bowang007
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds partial converter support for aten::linalg_norm. https://pytorch.org/docs/stable/generated/torch.linalg.norm.html. Non-None scalar ord arguments are not yet supported. Note that the string ord variant is a different schema and will fallback to torch.
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: