Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor changes #1482

Merged
merged 6 commits into from
Nov 27, 2022
Merged

Minor changes #1482

merged 6 commits into from
Nov 27, 2022

Conversation

yinghai
Copy link

@yinghai yinghai commented Nov 27, 2022 •
edited

Description

Remove compilation warning in test.
Remove redundant fixes in build rule.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: core Issues re: The core compiler component: tests Issues re: Tests labels Nov 27, 2022
frank-wei
frank-wei approved these changes Nov 27, 2022
View reviewed changes
Copy link
Contributor

@frank-wei frank-wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions bot added component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters labels Nov 27, 2022
@yinghai yinghai merged commit 720a45d into pytorch:master Nov 27, 2022
@yinghai yinghai deleted the lint branch November 27, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frank-wei frank-wei frank-wei approved these changes

@bowang007 bowang007 Awaiting requested review from bowang007

@narendasan narendasan Awaiting requested review from narendasan

@peri044 peri044 Awaiting requested review from peri044

Assignees
No one assigned
Labels
cla signed component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yinghai @frank-wei @facebook-github-bot