Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowering aten::pad to aten::constant_pad_nd/aten::reflection_padXd/aten::replication_padXd #1588

Merged
merged 3 commits into from
Feb 6, 2023

Conversation

ruoqianguo
Copy link
Contributor

Description

Lowering aten::pad to aten::constant_pad_nd/aten::reflection_padXd/aten::replication_padXd

Fixes #1566

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

…/aten::replication_padXd

Signed-off-by: Ruoqian Guo <ruoqiang@nvidia.com>
@github-actions github-actions bot added component: core Issues re: The core compiler component: lowering Issues re: The lowering / preprocessing passes component: tests Issues re: Tests labels Jan 12, 2023
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run the pre-commit tasks

Signed-off-by: Ruoqian Guo <ruoqiang@nvidia.com>
@ruoqianguo
Copy link
Contributor Author

Hi @narendasan , I have run the pre-commit tasks.

Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem fine, just make sure to add the new file to the CMake build system as well

Signed-off-by: Ruoqian Guo <ruoqiang@nvidia.com>
@ruoqianguo
Copy link
Contributor Author

Changes seem fine, just make sure to add the new file to the CMake build system as well

Hi @narendasan , I have added the new file to the CMake system. All checks have passed.

@peri044
Copy link
Collaborator

peri044 commented Feb 3, 2023

Expected this PR to make into 23.03 NGC release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: core Issues re: The core compiler component: lowering Issues re: The lowering / preprocessing passes component: tests Issues re: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot export a torchscript model to TensorRT.
4 participants