feat: Implement FP8 functionality #2763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: updates to trt api chore: trt 10 fixes chore: more fixes
author Dheeraj Peri <peri.dheeraj@gmail.com> 1711393059 -0700 committer Dheeraj Peri <peri.dheeraj@gmail.com> 1711393072 -0700 chore: minor updates chore: Fix save failures chore: minor fixes chore: remove duplicate bert test case chore: remove comments chore: add load api chore: minor updates chore: minor updates chore: minor updates chore: more updates
github-actions
bot
added
component: core
github-actions
bot
removed
component: core
zewenli98
reviewed
Jun 1, 2024
| def pre_export_lowering( | ||
| ep: torch.export.ExportedProgram, sample_inputs: Sequence[torch.Tensor] | ||
| ) -> torch.fx.GraphModule: | ||
| """Applies the lowering passes to a graph module after torch.export/ torch.compile and their decompositions, returns the modified GraphModule""" |
There was a problem hiding this comment.
after -> before?
I'm wondering what belong to pre_lowering and what belong to post_lowering?
There was a problem hiding this comment.
remove_detach belongs to pre_lowering (which happens before decompositions and other lowering passes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds FP8 & BF16 datatype support. It also implements converter for FP8 quantized ops.
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: