Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quantization api name consistency #375

Closed
HDCharles opened this issue Jun 15, 2024 · 2 comments
Closed

quantization api name consistency #375

HDCharles opened this issue Jun 15, 2024 · 2 comments
Assignees
@jerryzh168
Labels
enhancement New feature or request

Comments

@HDCharles
Copy link
Contributor

HDCharles commented Jun 15, 2024 •
edited
Loading

having the string to get a type of quantization and the constructor for that quantization as different text is super annoying.
https://github.com/pytorch/ao/blob/main/torchao/quantization/quant_api.py#L439-L443

quantize(model, int4wo()) ->works.......while quantize(model, "int4wo") -> error, wrong name

its a pain to have to remember which is which here, either both should work for the string or consolidate on a single one.

for that matter these also don't match

https://github.com/pytorch/ao/blob/main/torchao/quantization/quant_api.py#L310-L319
@HDCharles HDCharles changed the title quantization constructor names should match quantization api name consistency Jun 15, 2024
@msaroufim msaroufim added the enhancement New feature or request label Jun 15, 2024
@jerryzh168
Copy link
Contributor

yeah makes sense, I'll align the name, there was also a feedback from @gau-nernst about whether we should make it a Config class #384 (comment)

jerryzh168 added a commit to jerryzh168/ao that referenced this issue Jun 19, 2024
@jerryzh168
Refactor the API for quant method argument for quantize function
4faa66a 
Summary:
Addressing feedback from pytorch#384 and pytorch#375

Test Plan:
regression tests

python test/quantization/test_quant_api.py
python test/integration/test_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:
@jerryzh168 jerryzh168 mentioned this issue Jun 19, 2024
Merged
jerryzh168 added a commit to jerryzh168/ao that referenced this issue Jun 19, 2024
@jerryzh168
Refactor the API for quant method argument for quantize function
28680ff 
Summary:
Addressing feedback from pytorch#384 and pytorch#375

Test Plan:
regression tests

python test/quantization/test_quant_api.py
python test/integration/test_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:
jerryzh168 added a commit to jerryzh168/ao that referenced this issue Jun 19, 2024
@jerryzh168
Refactor the API for quant method argument for quantize function
e27b898 
Summary:
Addressing feedback from pytorch#384 and pytorch#375

Test Plan:
regression tests

python test/quantization/test_quant_api.py
python test/integration/test_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:
jerryzh168 added a commit to jerryzh168/ao that referenced this issue Jun 19, 2024
@jerryzh168
Refactor the API for quant method argument for quantize function
5fb966d 
Summary:
Addressing feedback from pytorch#384 and pytorch#375

Test Plan:
regression tests

python test/quantization/test_quant_api.py
python test/integration/test_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:
jerryzh168 added a commit to jerryzh168/ao that referenced this issue Jun 20, 2024
@jerryzh168
Refactor the API for quant method argument for quantize function
91a6dc5 
Summary:
Addressing feedback from pytorch#384 and pytorch#375

Test Plan:
regression tests

python test/quantization/test_quant_api.py
python test/integration/test_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:
jerryzh168 added a commit to jerryzh168/ao that referenced this issue Jun 21, 2024
@jerryzh168
Refactor the API for quant method argument for quantize function
20a2938 
Summary:
Addressing feedback from pytorch#384 and pytorch#375

Test Plan:
regression tests

python test/quantization/test_quant_api.py
python test/integration/test_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:
jerryzh168 added a commit that referenced this issue Jun 21, 2024
@jerryzh168
Refactor the API for quant method argument for quantize function (#400)
7a3f5a0 
Summary:
Addressing feedback from #384 and #375

Test Plan:
regression tests

python test/quantization/test_quant_api.py
python test/integration/test_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:
@jerryzh168
Copy link
Contributor

this is resolved now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jerryzh168 jerryzh168

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@msaroufim @jerryzh168 @HDCharles