Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding TorchScript test for F.phase_vocoder #1377

Closed
mthrok opened this issue Mar 9, 2021 · 2 comments
Closed

Adding TorchScript test for F.phase_vocoder #1377

mthrok opened this issue Mar 9, 2021 · 2 comments
Labels
contributions welcome good first issue help wanted module: tests

Comments

@mthrok
Copy link
Collaborator

mthrok commented Mar 9, 2021 •
edited

torchaudio.functional.phase_vocoder does not have TorchScript-compatibility test. We need this before adding native complex dtype support.

Steps

  1. Add test_phase_vocoder method in torchscript_consistency_impl.py
    Follow how the other functions are tested. It should be straightforward but if you need help feel free to ask here.

Build & testing

For setting up dev env, please refer to CONTRIBUTING.md.
Run the test with

(cd test && pytest torchaudio_unittest/functional/torchscript_consistency_cpu_test.py -k phase)
@mthrok mthrok changed the title Adding Torch test f Adding TorchScript test for F.phase_vocoder Mar 9, 2021
@mthrok mthrok mentioned this issue Mar 9, 2021
Closed
21 tasks
@mthrok
Copy link
Collaborator Author

mthrok commented Mar 10, 2021

#1379

@mthrok
Copy link
Collaborator Author

mthrok commented Mar 10, 2021

resolved by #1379

@mthrok mthrok closed this as completed Mar 10, 2021
mthrok pushed a commit to mthrok/audio that referenced this issue Dec 13, 2022
@holly1238 @brianjo
Tutorial left nav updates (pytorch#1377)
82d922b 
Updated tutorials left nav per this spreadsheet: https://docs.google.com/spreadsheets/d/189BUHi82VtpXwH1jAwQW8Z6jsonxKe4NrZJF7CxthKE/edit#gid=0.
 - Removed the "(prototype) Introduction to Named Tensors in PyTorch" tutorial
 - Moved several tutorials from the Frontend APIs section to a new Extending PyTorch section

Co-authored-by: Brian Johnson <brianjo@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contributions welcome good first issue help wanted module: tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mthrok