Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: The device-aware declaration of variable 'window' in istft function #240

Closed
ws-choi opened this issue Aug 16, 2019 · 1 comment

Comments

@ws-choi
Copy link

ws-choi commented Aug 16, 2019

Hello. I'm implementing an end-to-end model for speech enhancement.
During the implementation, I encountered the error caused by the conflict between cuda-cpu variables.
I think the variable window should be declared with the device of the given input (i.e. stft_matrix).
After fixing that line, my code is running well without errors.

Thank you.

p.s. I'm sorry that the post is not written in the given format.

@vincentqb
Copy link
Contributor

Good point. We should also consider inheriting the dtype from stft_matrix.

cpuhrsch pushed a commit that referenced this issue Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants