Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove instructions to build without building sox from README #1281

Merged
merged 2 commits into from Mar 2, 2021

Conversation

vincentqb
Copy link
Contributor

No description provided.

@vincentqb vincentqb changed the title Make alternative sox installation into a block Make alternative sox installation into a block in README Feb 18, 2021
@vincentqb vincentqb marked this pull request as ready for review February 19, 2021 00:33
@mthrok
Copy link
Collaborator

mthrok commented Feb 23, 2021

Considering the fact that we are now patching libsox and the process of building libsox has been stabilized, we should stop relying on external libsox.

@vincentqb
Copy link
Contributor Author

Indeed. I removed the instructions to build against external sox then.

@vincentqb vincentqb changed the title Make alternative sox installation into a block in README Remove instructions to build without building sox from README Feb 25, 2021
Copy link
Collaborator

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

mthrok pushed a commit to mthrok/audio that referenced this pull request Feb 26, 2021
* RL tutorial for playing Mario

* reduce logging frequency

* add deps to windows build
@vincentqb vincentqb merged commit 2209da2 into pytorch:master Mar 2, 2021
@vincentqb vincentqb deleted the readmeblock branch March 2, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants