Remove reference_cast in make_boxed_from_unboxed_functor (pytorch/pytorch#51319) #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Pull Request resolved: pytorch/pytorch#51319 We were going out of our way to accommodate `IValue::to<Tensor>` returning a copy of the inner Tensor. `IValue::toTensor` is capable of returning a reference without copying, so if we use it directly, we can allow kernels that want to take `Tensor &` to do so! As a bonus, we get reduced build times. ghstack-source-id: 121378961 Reviewed By: bhosmer Differential Revision: D26138549 fbshipit-source-id: b0f830527da360c542c815bef2f7e1692615b32a
mthrok
changed the title
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Dec 13, 2022
Fix lengths to cpu. See issue pytorch#1300 Co-authored-by: Brian Johnson <brianjo@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks a044625 on top of master, by taking into account the changes from #1285
Summary:
Pull Request resolved: pytorch/pytorch#51319
We were going out of our way to accommodate
IValue::to<Tensor>returning a copy of the inner Tensor.IValue::toTensoris capable of returning a reference without copying, so if we use it directly, we can allow kernels that want to takeTensor &to do so!As a bonus, we get reduced build times.
ghstack-source-id: 121378961
Reviewed By: bhosmer
Differential Revision: D26138549
fbshipit-source-id: b0f830527da360c542c815bef2f7e1692615b32a