Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed check_length from validate_input_file() #1312

Merged
merged 1 commit into from Feb 24, 2021
Merged

Removed check_length from validate_input_file() #1312

merged 1 commit into from Feb 24, 2021

Conversation

prabhat00155
Copy link
Contributor

@prabhat00155 prabhat00155 commented Feb 24, 2021 •
edited by mthrok

Some audio formats like gsm does not have valid frame numbers when opened. But libsox can properly handle these audios, so checking if length > 0 is not necessary and too strict.

mthrok
mthrok approved these changes Feb 24, 2021
View reviewed changes
Copy link
Collaborator

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

follow-up - add load test for GSM.

@prabhat00155
Copy link
Contributor Author

LGTM.

follow-up - add load test for GSM.

Shall I create a different PR for this?

@mthrok
Copy link
Collaborator

mthrok commented Feb 24, 2021

LGTM.
follow-up - add load test for GSM.

Shall I create a different PR for this?

If you have time and would like to, go for it.

@mthrok mthrok merged commit 086467a into pytorch:master Feb 24, 2021
@prabhat00155 prabhat00155 deleted the prabhat00155/fix_gsm branch February 24, 2021 20:45
prabhat00155 added a commit to prabhat00155/audio that referenced this pull request Feb 24, 2021
@prabhat00155
Removed check_length from validate_input_file() (pytorch#1312)
9372273 
Some audio formats like `gsm` does not have valid frame numbers when opened. But `libsox` can properly handle these audios, so checking if `length > 0` is not necessary and too strict.

(cherry picked from commit 086467a)
mthrok pushed a commit to mthrok/audio that referenced this pull request Feb 26, 2021
@jerryzh168
[quant] Guide on using FX Graph Mode Quantization and symbolic trace (p…
6ce4bb0 
…ytorch#1312)

* [quant] Guide on using FX Graph Mode Quantization and symbolic trace

* [quant] Guide on using FX Graph Mode Quantization and symbolic trace

* Update user guide title
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mthrok mthrok mthrok approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prabhat00155 @mthrok @facebook-github-bot