Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AudioMetaData.__str__ override #1339

Merged
merged 2 commits into from Mar 2, 2021

Conversation

majabojarska
Copy link
Contributor

Makes AudioMetaData print-friendly.
Closes #1323

@facebook-github-bot
Copy link
Contributor

Hi @majabojarska!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Copy link
Collaborator

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@majabojarska

Thanks opening the PR. Could you try removing the access to self.__class__ attribute?


def __str__(self):
return (
f"{self.__class__.__name__}("
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this is correct and more generic, TorchScript compiler has restriction in the kind of attributes it can access, and self.__class__ is not accessible. Can you hard-code it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tip. I commited the necessary change.

@mthrok mthrok merged commit 98d0d59 into pytorch:master Mar 2, 2021
@mthrok
Copy link
Collaborator

mthrok commented Mar 2, 2021

Thanks!

@majabojarska majabojarska deleted the audiometadata_str branch March 2, 2021 21:31
mthrok pushed a commit to mthrok/audio that referenced this pull request Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Making AudioMetaData print friendly
3 participants