Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Kaldi compatibility tests #1359

Merged
merged 3 commits into from Mar 5, 2021
Merged

Refactor Kaldi compatibility tests #1359

merged 3 commits into from Mar 5, 2021

Conversation

hwangjeff
Copy link
Contributor

@hwangjeff hwangjeff commented Mar 5, 2021

Stack from ghstack:

hwangjeff added a commit that referenced this pull request Mar 5, 2021
ghstack-source-id: 95de1f270b5341685c87d2952be25cef15da55b0
Pull Request resolved: #1359
hwangjeff added a commit that referenced this pull request Mar 5, 2021
ghstack-source-id: 311a5087b5838d0cf4a856777d2229ae81405c32
Pull Request resolved: #1359
Copy link
Collaborator

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

hwangjeff added a commit that referenced this pull request Mar 5, 2021
ghstack-source-id: 8b2dda11d24cdecc9733f10df04b0fe5780fc948
Pull Request resolved: #1359
@hwangjeff
Copy link
Contributor Author

thanks! made a small update to the test readme to account for the movement of files

@hwangjeff hwangjeff marked this pull request as ready for review March 5, 2021 17:42
@hwangjeff hwangjeff changed the base branch from gh/hwangjeff/2/base to master March 5, 2021 17:57
@hwangjeff hwangjeff merged commit 301a6e3 into master Mar 5, 2021
@hwangjeff hwangjeff deleted the gh/hwangjeff/2/head branch March 5, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants