Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove instructions for building sox from source #1365

Merged
merged 2 commits into from Mar 5, 2021

Conversation

carolineechen
Copy link
Contributor

remove BUILD_SOX=0 segment from CONTRIBUTING.md following #1338, which changes the behavior of BUILD_SOX=0

@mthrok
Copy link
Collaborator

mthrok commented Mar 5, 2021

Could you also remove the mention to libsox in README?

libsox v14.3.2 or above (only required when building from source)

@carolineechen carolineechen changed the title update build_sox in contributing update readme/contributing Mar 5, 2021
@carolineechen carolineechen changed the title update readme/contributing remove instructions for building sox from source Mar 5, 2021
@carolineechen carolineechen merged commit 7b85f1c into pytorch:master Mar 5, 2021
@carolineechen carolineechen deleted the update_sox_contrib branch March 5, 2021 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants