Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor sox_io load_test #1394

Merged
merged 1 commit into from Mar 17, 2021
Merged

Refactor sox_io load_test #1394

merged 1 commit into from Mar 17, 2021

Conversation

carolineechen
Copy link
Contributor

clean up load_test.py unit tests by reducing several assert_XXX functions into one main assert_format function

mthrok
mthrok approved these changes Mar 17, 2021
View reviewed changes
Copy link
Collaborator

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@carolineechen carolineechen merged commit 80a8739 into pytorch:master Mar 17, 2021
@carolineechen carolineechen deleted the refactor_load_test branch March 17, 2021 14:43
mthrok pushed a commit to mthrok/audio that referenced this pull request Dec 13, 2022
@brianjo
Update profiler_recipe.py (pytorch#1394)
468a52d 
Removes note.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mthrok mthrok mthrok approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@carolineechen @mthrok @facebook-github-bot