Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checksum for the YESNO dataset #1405

Merged
merged 1 commit into from Mar 29, 2021
Merged

Fix checksum for the YESNO dataset #1405

merged 1 commit into from Mar 29, 2021

Conversation

danieleds
Copy link
Contributor

@danieleds danieleds commented Mar 22, 2021

The length of the checksum for the YESNO dataset is inconsistent with the specified algorithm (MD5) and its value does not correspond to the other supported algorithm (sha256).

This PR updates the hash to the correct sha256 value.

@facebook-github-bot
Copy link
Contributor

Hi @danieleds!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@mthrok
Copy link
Collaborator

mthrok commented Mar 29, 2021

Hi @danieleds

Thanks for making the PR.

@carolineechen Could you take a look at this?

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Contributor

@carolineechen carolineechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@carolineechen carolineechen merged commit 198f83e into pytorch:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants