Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Autograd test for T.Resample #1416

Merged
merged 3 commits into from Apr 5, 2021

Conversation

krishnakalyan3
Copy link
Contributor

@krishnakalyan3 krishnakalyan3 commented Apr 1, 2021

ref #1414

cc: @mthrok

@krishnakalyan3
Copy link
Contributor Author

We need parameters for Resample. If yes what should be the range for orig_freq, new_freq?.

https://github.com/pytorch/audio/blob/master/torchaudio/transforms.py#L651

@mthrok
Copy link
Collaborator

mthrok commented Apr 2, 2021

https://github.com/pytorch/audio/blob/master/torchaudio/transforms.py#L651

@krishnakalyan3

Thanks for the suggestion. I think we should test at least three cases. down sampling, up sampling and no sampling (just in case).
we can try something like orig_freq, new_freq = (8000, 8000), (8000, 4000), (4000, 8000).

@mthrok mthrok mentioned this pull request Apr 2, 2021
15 tasks
@mthrok mthrok changed the title Autograd tests for Transforms Resample Add Autograd test for T.Resample Apr 2, 2021
@mthrok mthrok merged commit 90311ed into pytorch:master Apr 5, 2021
@mthrok
Copy link
Collaborator

mthrok commented Apr 5, 2021

Thanks!

@krishnakalyan3 krishnakalyan3 deleted the autograd-test-resample branch April 5, 2021 17:31
mthrok pushed a commit to mthrok/audio that referenced this pull request Dec 13, 2022
Needed to temporarily disable intermediate_source/spatial_transformer_tutorial.py for a download issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants