Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add autograd test for T.ComputeDeltas #1422

Merged
merged 7 commits into from Apr 5, 2021
Merged

Add autograd test for T.ComputeDeltas #1422

merged 7 commits into from Apr 5, 2021

Conversation

yoyololicon
Copy link
Collaborator

@yoyololicon yoyololicon commented Apr 3, 2021 •
edited

ref #1414
cc @mthrok

I found the implementation of F.compute_deltas is quite inefficient, will make another PR for it.

@mthrok mthrok merged commit e964f93 into pytorch:master Apr 5, 2021
@mthrok
Copy link
Collaborator

mthrok commented Apr 5, 2021

Thanks!

@mthrok mthrok mentioned this pull request Apr 5, 2021
Closed
15 tasks
@yoyololicon yoyololicon deleted the compute-deltas-autograd-test branch April 6, 2021 00:19
carolineechen pushed a commit to carolineechen/audio that referenced this pull request Apr 30, 2021
@yoyololicon
Add autograd test for T.ComputeDeltas (pytorch#1422)
68eb982
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yoyololicon @mthrok @facebook-github-bot