Run transform librosa compatibility test on CUDA as well #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolineechen
approved these changes
Apr 7, 2021
| from .librosa_compatibility_test_impl import TransformsTestBase | ||
|
|
||
|
|
||
| class TestTransforms(TransformsTestBase, PytorchTestCase): |
There was a problem hiding this comment.
So I started out as very verbose test class name but in #1436, it was pointed out that I forgot to change it from CPU to CUDA when I copy pasted it, and that made me wonder if we need to be that verbose for this. CPU tests and CUDA tests are separated on file-basis, so there is not a case where you look at test log and do not know which device it is running the test.
So I am learning towards removing CPU/CUDA from the name of test class.
What do you think?
There was a problem hiding this comment.
Yup, that makes sense to me. We can remove CPU/CUDA from test class names moving forward
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #1436 this PR ports librosa compatibility test for Transforms to CPU/CUDA.