Clarify sox_effects.apply_effects_tensor as CPU-only in Doc
#1459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthrok
reviewed
Apr 19, 2021
There was a problem hiding this comment.
The change looks good. Can you also add Note: section to clarify it?
Say
Note:
This function only works on CPU Tensors.
Like in
audio/torchaudio/sox_effects/sox_effects.py
Lines 14 to 17 in 14dd917
mthrok
requested changes
Apr 21, 2021
| @@ -14,6 +14,7 @@ def init_sox_effects(): | |||
|
|
|||
| Note: | |||
| You do not need to call this function manually. It is called automatically. | |||
| This function only works on CPU Tensors. | |||
There was a problem hiding this comment.
This is not the right function. The note has to be added to apply_effects_tensor function.
There was a problem hiding this comment.
Ah got a bit confused. Should have read your comments carefully.
mthrok
approved these changes
Apr 22, 2021
carolineechen
pushed a commit
to carolineechen/audio
that referenced
this pull request
Apr 30, 2021
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Dec 13, 2022
* Fix bugs in pipeline tutorial with respect to batch size. Summary: As described in pytorch/pytorch#55036, certain modules were not handling batch size correctly. * Rebase Co-authored-by: pritam <pritam.damania@fb.com> Co-authored-by: Brian Johnson <brianjo@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1456