Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly disable wavpack when building SoX #1462

Merged
merged 1 commit into from Apr 19, 2021

Conversation

mthrok
Copy link
Collaborator

@mthrok mthrok commented Apr 19, 2021

Ref #1461

@mthrok mthrok changed the title Explicitly disable wavpack Explicitly disable wavpack when building SoX Apr 19, 2021
@rien333
Copy link

rien333 commented Apr 19, 2021

Works great, thanks!

Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mthrok mthrok merged commit 7355d9f into pytorch:master Apr 19, 2021
@mthrok mthrok deleted the disable-wavpack branch April 19, 2021 16:33
carolineechen pushed a commit to carolineechen/audio that referenced this pull request Apr 30, 2021
`wavpack` is a format not supported/tested in torchaudio.
Leaving the option blank can cause the issue like pytorch#1461 in untested environment.
mthrok pushed a commit to mthrok/audio that referenced this pull request Dec 13, 2022
* Update instructions to copy all files

See issue raised here: pytorch/vision#3630
Basically, just copying the selected files cause import errors, since the coco_eval and coco_utils need to be copied as well. 
@NicolasHug pinging you here.

Thanks!

* Update torchvision_tutorial.rst

Update instructions about how to install pycocotools

Co-authored-by: holly1238 <77758406+holly1238@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants