Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor functional test #1463

Merged
merged 1 commit into from Apr 19, 2021
Merged

Refactor functional test #1463

merged 1 commit into from Apr 19, 2021

Conversation

dhthompson
Copy link
Contributor

  • Refactor functional test logic into one place, functional_impl.py
  • Tidy imports

Local test plan:
cd test && pytest torchaudio_unittest/functional

@dhthompson
Refactor functional test
ea83eaa 
- Refactor functional test logic into one place, `functional_impl.py`
- Tidy imports
@dhthompson dhthompson requested a review from mthrok April 19, 2021 18:36
@dhthompson dhthompson closed this Apr 19, 2021
@dhthompson dhthompson reopened this Apr 19, 2021
@mthrok mthrok closed this Apr 19, 2021
@mthrok mthrok reopened this Apr 19, 2021
mthrok
mthrok reviewed Apr 19, 2021
View reviewed changes
Copy link
Collaborator

@mthrok mthrok left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's wait until the tests in CI pass.

For a future work, we can run these tests (except create_fb_matrix, which does not depend on device /dtypes) in CPU/CUDA by setting the device and dtype of Tensors passed to the tested functions.

@mthrok mthrok merged commit b059f08 into pytorch:master Apr 19, 2021
@mthrok
Copy link
Collaborator

mthrok commented Apr 19, 2021

Thanks!

carolineechen pushed a commit to carolineechen/audio that referenced this pull request Apr 30, 2021
@dhthompson
Refactor functional test (pytorch#1463)
f32b0c9 
- Put functional test logic into one place, `functional_impl.py`
- Tidy imports
mthrok pushed a commit to mthrok/audio that referenced this pull request Dec 13, 2022
@SimonGDunne @holly1238
Fix formatting typo preventing rendering of note (pytorch#1463)
6738ff1 
Co-authored-by: holly1238 <77758406+holly1238@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mthrok mthrok mthrok left review comments

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dhthompson @mthrok @facebook-github-bot