Add warning for non-integer resampling frequencies #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolineechen
force-pushed
the
float-resample-warning
branch
from
cdc8aaf
to
5f3feed
Compare
mthrok
approved these changes
May 5, 2021
torchaudio/functional/functional.py
Outdated
| "so please manually convert frequencies to integer values that maintain the ratio" | ||
| "prior to passing them into the function" | ||
| "Example: To downsample a 44100 hz waveform by a factor of 8, you can use" | ||
| "`orig_freq=8` and `new_freq=1` instead of `orig_freq=44100` and `new_freq=5512.5`" |
There was a problem hiding this comment.
I think we can go farther and say it will raise an error in the future.
@cpuhrsch what do you think?
There was a problem hiding this comment.
I think it's fine if we throw an exception in the next release, but I'd create a pre-emptive issue for this and link it here so that users can chime in whether they want this or not. The overall topic seems to be "non-integral sampling rates", so maybe we can link to an umbrella issue like that.
There was a problem hiding this comment.
Can you plan the future changes and make a note in #1487, then mention that in the message ?
added 2 commits
May 10, 2021 13:21
carolineechen
force-pushed
the
float-resample-warning
branch
from
cc626c6
to
665694b
Compare
carolineechen
force-pushed
the
float-resample-warning
branch
from
665694b
to
5c65489
Compare
mthrok
reviewed
May 21, 2021
| assert len(w) == 1 | ||
|
|
||
|
|
||
| class FunctionalComplex(TestBaseMixin): |
There was a problem hiding this comment.
@carolineechen I think this was introduced by mistake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add warning and suggestion when the frequency inputs to the resample function are not integer values
cc #1487