New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1511] Add deprecation warning to MelScale for unset weight #1515
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @brianw
Thanks for the contribution. Overall it looks good.
Issue a warning if `n_stft` is unitialized or zero in construction. pytorch#1511
Rebased and pushed with PR feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Please fix the some typos.
Co-authored-by: moto <855818+mthrok@users.noreply.github.com>
Co-authored-by: moto <855818+mthrok@users.noreply.github.com>
Argh, sorry I missed those, they were pretty obvious. |
Thanks! |
Co-authored-by: Holly Sweeney <77758406+holly1238@users.noreply.github.com>
Issue a warning if
n_stft
is unitialized or zero in construction.#1511