Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1511] Add deprecation warning to MelScale for unset weight #1515

Merged
merged 3 commits into from May 19, 2021

Conversation

brianw
Copy link
Contributor

@brianw brianw commented May 19, 2021

Issue a warning if n_stft is unitialized or zero in construction.

#1511

Copy link
Collaborator

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @brianw

Thanks for the contribution. Overall it looks good.

torchaudio/transforms.py Outdated Show resolved Hide resolved
torchaudio/transforms.py Outdated Show resolved Hide resolved
Issue a warning if `n_stft` is unitialized or zero in construction.

pytorch#1511
@brianw
Copy link
Contributor Author

brianw commented May 19, 2021

Rebased and pushed with PR feedback.

Copy link
Collaborator

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please fix the some typos.

torchaudio/transforms.py Outdated Show resolved Hide resolved
torchaudio/transforms.py Outdated Show resolved Hide resolved
brianw and others added 2 commits May 19, 2021 17:53
Co-authored-by: moto <855818+mthrok@users.noreply.github.com>
Co-authored-by: moto <855818+mthrok@users.noreply.github.com>
@brianw
Copy link
Contributor Author

brianw commented May 19, 2021

Argh, sorry I missed those, they were pretty obvious.

@mthrok mthrok merged commit 264ab15 into pytorch:master May 19, 2021
@mthrok
Copy link
Collaborator

mthrok commented May 19, 2021

Thanks!

@brianw brianw deleted the brianw/1511 branch May 19, 2021 21:03
mthrok pushed a commit to mthrok/audio that referenced this pull request Dec 13, 2022
Co-authored-by: Holly Sweeney <77758406+holly1238@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants