Add F.resample torchscript test #1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthrok
reviewed
May 19, 2021
test/torchaudio_unittest/functional/torchscript_consistency_impl.py
Outdated
Show resolved
Hide resolved
mthrok
approved these changes
May 19, 2021
carolineechen
force-pushed
the
resample-functional-torchscript
branch
from
725d269
to
0c41e01
Compare
carolineechen
force-pushed
the
resample-functional-torchscript
branch
from
0c41e01
to
0623b3f
Compare
carolineechen
commented
May 20, 2021
mthrok
reviewed
May 20, 2021
test/torchaudio_unittest/functional/torchscript_consistency_impl.py
Outdated
Show resolved
Hide resolved
| # kaiser_window | ||
| if beta is None: | ||
| beta = 14.769656459379492 | ||
| beta_tensor = torch.tensor(float(beta)) |
There was a problem hiding this comment.
😮 Nicely done. I did not know optional type refinement can be done this elegantly.
mthrok
approved these changes
May 20, 2021
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Dec 13, 2022
* Update rpc_ddp_tutorial.rst * Delete advanced_source/rpc_ddp_tutorial directory * Create main.py * Update rpc_ddp_tutorial.rst
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Dec 13, 2022
This reverts commit 7e19410.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add torchscriptiibility test for
F.resample