Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IO function from batch_consistency_test #1521

Merged
merged 1 commit into from May 22, 2021

Conversation

jachymuv
Copy link
Contributor

Replace IO function torchaudio.load() usage in test by on-the-fly generated white noise

@facebook-github-bot
Copy link
Contributor

Hi @jachymuv!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Collaborator

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jachymuv

Thanks for the contribution. It overall looks good.
Could you change sample_rate=8000 and duration=1?
For this test, we do not need such a long audio data.

@jachymuv jachymuv force-pushed the batch_consistency_test_remove_io branch from cf9fff0 to 21e05d8 Compare May 21, 2021 13:56
@jachymuv
Copy link
Contributor Author

OK, changed to duration=1 and sampling_rate=8000. The last test for spectral centroid I left intact for this PR, so there is still sr=44100 as it was before.

Copy link
Collaborator

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. Thanks!

But the Windows CI is having infrastructure issue, let me come back and rerun tests before merging this.

@mthrok mthrok merged commit c4a1702 into pytorch:master May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants