Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add file path to io errors #1523

Merged
merged 7 commits into from May 24, 2021
Merged

Add file path to io errors #1523

merged 7 commits into from May 24, 2021

Conversation

deniskokarev
Copy link
Contributor

Add file path in error messages of I/O operations #1503
cc @mthrok

@facebook-github-bot
Copy link
Contributor

Hi @deniskokarev!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

mthrok
mthrok requested changes May 22, 2021
View reviewed changes
Copy link
Collaborator

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Could you also add test for info function?

test/torchaudio_unittest/backend/sox_io/load_test.py Outdated Show resolved Hide resolved
test/torchaudio_unittest/backend/sox_io/load_test.py Outdated Show resolved Hide resolved
test/torchaudio_unittest/backend/sox_io/save_test.py Outdated Show resolved Hide resolved
test/torchaudio_unittest/backend/sox_io/save_test.py Outdated Show resolved Hide resolved
test/torchaudio_unittest/backend/sox_io/save_test.py Outdated Show resolved Hide resolved
deniskokarev and others added 2 commits May 24, 2021 09:23
@deniskokarev @mthrok
Apply suggestions from code review
7cff122 
Co-authored-by: moto <855818+mthrok@users.noreply.github.com>
@deniskokarev
Adding TestInfoNoSuchFile and making cosmetic changes for save_test.p…
f8afc1d 
…y review recommendations
@deniskokarev deniskokarev requested a review from mthrok May 24, 2021 14:59
mthrok
mthrok approved these changes May 24, 2021
View reviewed changes
Copy link
Collaborator

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@mthrok mthrok merged commit d272eb0 into pytorch:master May 24, 2021
@deniskokarev deniskokarev deleted the Add_file_path_to_io_errors branch May 25, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mthrok mthrok mthrok approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@deniskokarev @facebook-github-bot @mthrok