Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate kaldi resample #1533

Merged
merged 1 commit into from May 31, 2021
Merged

Deprecate kaldi resample #1533

merged 1 commit into from May 31, 2021

Conversation

mthrok
Copy link
Collaborator

@mthrok mthrok commented May 31, 2021 •
edited

Deprecating torchaudio.compliance.kaldi.resample_waveform, which is exactly same as torchaudio.functional.resample.

@mthrok mthrok added this to the v0.9 milestone May 31, 2021
This was referenced May 31, 2021
Closed
Closed
carolineechen
carolineechen approved these changes May 31, 2021
View reviewed changes
Copy link
Contributor

@carolineechen carolineechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mthrok mthrok merged commit 87be920 into pytorch:master May 31, 2021
@mthrok mthrok deleted the deprecate-kaldi-resample branch May 31, 2021 18:48
@carolineechen carolineechen mentioned this pull request Jun 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carolineechen carolineechen carolineechen approved these changes

@vincentqb vincentqb Awaiting requested review from vincentqb

@cpuhrsch cpuhrsch Awaiting requested review from cpuhrsch

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
v0.9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mthrok @carolineechen @facebook-github-bot