Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cherry-picked 0.9] Ensure resampling identity is unchanged #1537

Merged
merged 1 commit into from Jun 1, 2021
Merged

[Cherry-picked 0.9] Ensure resampling identity is unchanged #1537

merged 1 commit into from Jun 1, 2021

Conversation

carolineechen
Copy link
Contributor

@carolineechen carolineechen commented Jun 1, 2021 •
edited

  • return the original waveform when original and new sampling rates are the same for resample
  • add unit tests for identity case
  • remove a unit test that tests compatibility against kaldi's resample, since it is being deprecated

@carolineechen carolineechen requested a review from mthrok June 1, 2021 16:58
mthrok
mthrok approved these changes Jun 1, 2021
View reviewed changes
Copy link
Collaborator

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you cherry pick this to release/0.9 branch as well?

@carolineechen carolineechen merged commit fad19fa into pytorch:master Jun 1, 2021
carolineechen pushed a commit that referenced this pull request Jun 1, 2021
Ensure resampling identity is unchanged (#1537)
66fe5a3
@mthrok mthrok changed the title Ensure resampling identity is unchanged [Cherry-picked 0.9] Ensure resampling identity is unchanged Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mthrok mthrok mthrok approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@carolineechen @mthrok @facebook-github-bot