[Cherry-picked 0.9] Update MelSpectrogram power annotation #1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolineechen
approved these changes
Jun 14, 2021
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Jun 14, 2021
Mel scale frequency is in general defined/used on power spectrogram and as far as we know, it is not defined for raw (complex value) spectrogram. When `power=None` (when intermediate spectrogram is complex-valued), `MelSpectrogram` fails because of extra dimension (when using pseudo complex) or type mismatch between `torch.float` and torch.cfloat` (when using native complex). This commit changes type annotation so that power is only float.
mthrok
changed the title
mthrok
changed the title
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Dec 13, 2022
) This reverts commit 03341a2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1570
Mel scale frequency is in general defined/used on power spectrogram and as far as we know, it is not defined for raw (complex value) spectrogram. When
power=None,MelSpectrogramfails because of extra dimension (when using pseudo complex) or type mismatch between float and cfloat (when using native complex).This PR changes type annotation so that power is only float.
@carolineechen Can you review? I think we can cherry-pick this to 0.9. Aldo Do you think this should be labeled BC-breaking?
power=Nonenever worked, so it does not break anything.