Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/0.10] Cherry pick #1966 to release/0.10 #2054

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

mthrok
Copy link
Collaborator

@mthrok mthrok commented Nov 30, 2021

Cherry-picking


@mthrok mthrok changed the title Cherry pick #2050 and #1966 to release/0.10 [release/0.10] Cherry pick #2050 and #1966 to release/0.10 Nov 30, 2021
Copy link
Member

@nateanl nateanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mthrok mthrok changed the title [release/0.10] Cherry pick #2050 and #1966 to release/0.10 [release/0.10] Cherry pick #1966 to release/0.10 Dec 3, 2021
This commit changes the build process so that the third party code are fetched automatically when `setup.py` is invoked.

This is to allow
1. `build_sdist` to contain the third party library codes, so that source code distribution created at the time release tag is created is complete.
2. It makes it possible to do `pip install https://github.com/pytorch/audio.git`.
    Example:
    ```
    !pip install 'cmake>=3.18' ninja
    !pip install --verbose git+https://github.com/pytorch/audio.git@auto-source
    ```
@mthrok mthrok merged commit 6b7342d into pytorch:release/0.10 Dec 3, 2021
@mthrok mthrok deleted the cherry-pick branch December 3, 2021 22:42
mthrok pushed a commit to mthrok/audio that referenced this pull request Dec 13, 2022
* Add a TorchMultimodal tutorial for FLAVA finetuning
Co-authored-by: Nikita Shulga <nshulga@fb.com>
Co-authored-by: Svetlana Karslioglu <svekars@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants