Increasing test coverage (ASR demo) #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentqb
reviewed
Aug 20, 2019
vincentqb
reviewed
Aug 20, 2019
There was a problem hiding this comment.
Thanks for looking into this! I hope dependencies won't constantly break this test :)
I like that this is testing fbank, load_wave, and Resample at a higher level. pytorch/pytorch#24344 for reference
vincentqb
added a commit
to vincentqb/audio
that referenced
this pull request
Sep 6, 2019
This reverts commit ed17513.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the ASR demo, we should test that the
transcribe_fileworks correctly (i.e. reads "sample.wav" and produces[['THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG']]).To do this, functions inside
examples/interactive_asr/asr.pyare moved intoexamples/interactive_asr/utils.pyso that the functions can be called inexamples/test/test_interactive_asr.py. This also reduces the number of lines of code forasr.pyThe Travis CI has been updated accordingly