-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flake8 #266
flake8 #266
Conversation
@@ -19,18 +19,16 @@ | |||
|
|||
from collections import deque | |||
|
|||
import librosa | |||
import numpy as np |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want the numpy dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use it on line 225, but it'd be nice to get rid of it. I was mostly cleaning lint, but feel free to suggest a replacement :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. It could be solved in a separate PR. Just notice it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the binary tests fail?
Build with conda has been failing recently. This is something that will have to be looked at.
from here. |
Addressing some lint, and unused variables.